fix: link check on wikipedia#5990
Conversation
LesnyRumcajs
requested review from
akaladarshi and
hanabi1224
and removed request for
a team
WalkthroughAdded a new exclude entry "wikipedia.org" to .config/lychee.toml with a preceding comment noting bot protection/403 errors. No other files or configurations were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.config/lychee.toml (3)
22-24: Anchor the exclude to the scheme+host to avoid accidental matches in query strings.As written, the regex fragment "wikipedia.org" can match anywhere in the URL string (including query parameters on other domains), potentially excluding unrelated links. Anchor to the start and host so only Wikipedia links are skipped. Also future-proof the comment with an explicit date.
- # Bot protection / 403 Forbidden errors - "wikipedia.org", + # Bot protection / 403 Forbidden errors (added 2025-08-25). Anchor to scheme+host to avoid false positives. + "^https?://([a-z0-9-]+\\.)?wikipedia\\.org(/|$)",
22-24: Add a reminder to revisit the exclusion.This blanket domain exclude trades reliability for coverage. Add a short TODO with context so we remember to re-enable checks if/when Wikipedia relaxes bot protection or lychee gets a first-class workaround.
# Bot protection / 403 Forbidden errors (added 2025-08-25). Anchor to scheme+host to avoid false positives. "^https?://([a-z0-9-]+\\.)?wikipedia\\.org(/|$)", + # TODO(ops): Re-evaluate this exclusion quarterly; lift once link checks stop returning 403 in CI. + # See CI run: https://github.com/ChainSafe/forest/actions/runs/17208198974/job/48813396939I can open a tracking issue with a small reminder bot if you want.
22-24: Add exclusion for Wikipedia’s shortlink domain (w.wiki)We ran an extended scan across documentation and source files (md, mdx, txt, rs, ts, tsx, html, js, jsx, json, yml, yaml) and did not find any existing
https://w.wiki/links. Nonetheless, adding this exclusion will proactively prevent 403 Forbidden errors when Lychee encounters shortlinks in the future.• File:
.config/lychee.toml
• Context: around lines 22–24Proposed diff:
# Bot protection / 403 Forbidden errors (added 2025-08-25). Anchor to scheme+host to avoid false positives. "^https?://([a-z0-9-]+\.)?wikipedia\.org(/|$)", + # Wikipedia shortlinks can 403 under the same bot protection + "^https?://w\.wiki/.*",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.config/lychee.toml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: LesnyRumcajs
PR: ChainSafe/forest#5907
File: src/rpc/methods/state.rs:523-570
Timestamp: 2025-08-06T15:44:33.467Z
Learning: LesnyRumcajs prefers to rely on BufWriter's Drop implementation for automatic flushing rather than explicit flush() calls in Forest codebase.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: tests
- GitHub Check: tests-release
- GitHub Check: Build MacOS
- GitHub Check: Build Ubuntu
- GitHub Check: cargo-publish-dry-run
- GitHub Check: Build forest binaries on Linux AMD64
- GitHub Check: All lint checks
- GitHub Check: Analyze (rust)
- GitHub Check: Analyze (go)
🔇 Additional comments (1)
.config/lychee.toml (1)
22-24: Pragmatic fix.Given CI is blocked by 403s, excluding Wikipedia is a reasonable, low-risk workaround that aligns with how we already treat other bot-protected hosts in this config.
|
Thanks! 🙏 |
3 participants
Summary of changes
Changes introduced in this pull request:
https://github.com/ChainSafe/forest/actions/runs/17208198974/job/48813396939
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Summary by CodeRabbit